Skip to content

Conversation

@nlou9
Copy link
Member

@nlou9 nlou9 commented Jul 16, 2025

As part of the depot migration task, replace release-tools with confluent-devtools which has been preinstalled on CI build agent. It is not necessary to pip install it in semaphore.yaml.

One Pager: https://confluentinc.atlassian.net/wiki/spaces/TOOLS/pages/4020831896/Depot+-+Python+Walled+Garden+Repository

@nlou9 nlou9 marked this pull request as ready for review August 6, 2025 23:14
Copilot AI review requested due to automatic review settings August 6, 2025 23:14
@nlou9 nlou9 requested a review from a team as a code owner August 6, 2025 23:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from confluent-release-tools to confluent-devtools as part of a depot migration task to establish a Python walled garden repository. The change updates the CI/CD pipeline dependency to use the new tooling package.

  • Replaces confluent-release-tools with confluent-devtools in the Semaphore CI configuration

- export BUILD_NUMBER=$(echo $SEMAPHORE_WORKFLOW_ID | cut -f1 -d"-")
- export BRANCH_TAG=$(echo $SEMAPHORE_GIT_BRANCH | tr / -)
# For PR Builds using Packaging
- pip install confluent-release-tools
Copy link
Member

@duongkame duongkame Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The desc says "replace release-tools with confluent-devtools" but there's only one removal of confluent-release-tools (without the replacement of confluent-devtools) in this PR. Is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the confluent-devtools has already been preinstalled on CI build agent.

Copy link
Member

@duongkame duongkame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nlou9 nlou9 merged commit e71e0ff into master Nov 4, 2025
2 checks passed
@nlou9 nlou9 deleted the nllou/depot branch November 4, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants